Re: [PATCH 093/122] USB: musb_gadget: remove pointless loop

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello.

Greg Kroah-Hartman wrote:

From: Sergei Shtylyov <sshtylyov@xxxxxxxxxxxxx>

Remove the pointless 'do () while (0)' loop from musb_g_tx() -- it
makes this function symmetric to musb_g_rx()...

Signed-off-by: Sergei Shtylyov <sshtylyov@xxxxxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxx>

Greg, what was wrong with replacing this broken patch with the corrected one (that I sent in time), and that you were later specifically asked to replace this one by Anad Gadiyar?
Now I'll have to cook up another hot fix... :-/

+			if (!musb_ep->desc) {
+				DBG(4, "%s idle now\n",
+					musb_ep->end_point.name);
+				return;
+			} else
+				request = next_request(musb_ep);

  This fragment may cause txstate() below to blow up...

 		}
- } while (0);
+		txstate(musb, to_musb_request(request));
+	}
 }
/* ------------------------------------------------------------ */

WBR, Sergei


--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux