Hi! > > From: Ondrej Jirman <megi@xxxxxx> > > > > This is driver for ANX7688 USB-C HDMI, with flashing and debugging > > features removed. ANX7688 is rather criticial piece on PinePhone, > > there's no display and no battery charging without it. > > Don't remove the flashing part. Some Pinephones come without the firmware > in the past. Even recently, I've seen some people in the Pine chat > asking how to flash the firmware on some old PinePhone. > > It's a safe operation that can be done at any time and can only be done > from the kernel driver. I can re-add it later, but initial merge will be tricky enough as-is. > > There's likely more work to be done here, but having basic support > > in mainline is needed to be able to work on the other stuff > > (networking, cameras, power management). > > > > Signed-off-by: Ondrej Jirman <megi@xxxxxx> > > I should be second in order of sign-offs. Martijn wrote a non-working skeleton > https://megous.com/git/linux/commit/?h=pp-5.7&id=30e33cefd7956a2b49fb27008b4af9d868974e58 > driver. Then I picked it up and developed it over years to a working thing. > Almost none of the skeleton remains. I believe From: should match First signed-off. I guess Martijn should be marked as co-developed-by or something like that? > License is GPLv2. Ok. > > + ret = of_property_read_variable_u32_array(dev->of_node, "sink-caps", > > + anx7688->snk_caps, > > + 1, ARRAY_SIZE(anx7688->snk_caps)); > > + if (ret < 0) { > > + dev_err(dev, "failed to get sink-caps from DT\n"); > > + return ret; > > + } > > ^^^ The driver will need to follow usb-c-connector bindings and it will need > a bindings documentation for itself. > > That's one of the missing things that I did not implement, yet. Yep, I fought with device trees for few days. I should have yaml ready. Best regards, Pavel -- People of Russia, stop Putin before his war on Ukraine escalates.
Attachment:
signature.asc
Description: PGP signature
