On Sat, 13 Jan 2024 at 12:52, Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> wrote:
>
> On 13.01.2024 06:42, Dmitry Baryshkov wrote:
> > Plug in USB-C related bits and pieces to enable USB role switching and
> > USB-C orientation handling for the Qualcomm RB2 board.
> >
> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> > ---
> > arch/arm64/boot/dts/qcom/qrb4210-rb2.dts | 62 ++++++++++++++++++++++++++++++++
> > arch/arm64/boot/dts/qcom/sm6115.dtsi | 38 ++++++++++++++++++++
> > 2 files changed, 100 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts
> > index 52f31f3166c2..a96e3afb65bc 100644
> > --- a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts
> > +++ b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts
> > @@ -6,8 +6,10 @@
> > /dts-v1/;
> >
> > #include <dt-bindings/leds/common.h>
> > +#include <dt-bindings/usb/pd.h>
> > #include "sm4250.dtsi"
> > #include "pm6125.dtsi"
> > +#include "pmi632.dtsi"
> >
> > / {
> > model = "Qualcomm Technologies, Inc. QRB4210 RB2";
> > @@ -256,6 +258,53 @@ kypd_vol_up_n: kypd-vol-up-n-state {
> > };
> > };
> >
> > +&pmi632_typec {
> > + status = "okay";
> > +
> > + connector {
> > + compatible = "usb-c-connector";
> > +
> > + power-role = "dual";
> > + data-role = "dual";
> > + self-powered;
> > +
> > + source-pdos = <PDO_FIXED(5000, 3000,
> > + PDO_FIXED_DUAL_ROLE |
> > + PDO_FIXED_USB_COMM |
> > + PDO_FIXED_DATA_SWAP)>;
> > + sink-pdos = <PDO_FIXED(5000, 500,
> > + PDO_FIXED_DUAL_ROLE |
> > + PDO_FIXED_USB_COMM |
> > + PDO_FIXED_DATA_SWAP)>;
> > + op-sink-microwatt = <10000000>;
> So RB2 can provide 15 watts over the USB-C port, consume 2.5 but
> requires 10? That doesn't make a whole lot of sense..
>
> Unless I'm reading this wrong..
Let me double-check the properties and the docs before answering.
>
> > +&usb_dwc3 {
> > + usb-role-switch;
>
> Since this is a dual-role controller, I think this could live in the SoC
Sure. Should we update other boards too?
> DT
>
> > +};
> > +
> > +&usb_dwc3_hs {
> > + remote-endpoint = <&pmi632_hs_in>;
> > +};
> > +
> > &usb_hsphy {
> > vdd-supply = <&vreg_l4a_0p9>;
> > vdda-pll-supply = <&vreg_l12a_1p8>;
> > @@ -618,10 +675,15 @@ &usb_hsphy {
> > &usb_qmpphy {
> > vdda-phy-supply = <&vreg_l4a_0p9>;
> > vdda-pll-supply = <&vreg_l12a_1p8>;
> > + orientation-switch;
>
> Similarly, if this doesn't kaboom w/ our implementation too much, the
> PHY itself has orientation detection capabilities
>
> Konrad
--
With best wishes
Dmitry
