On 12/7/2023 8:58 PM, Johan Hovold wrote:
On Mon, Dec 04, 2023 at 03:39:46PM +0530, Krishna Kurapati wrote:
For wakeup to work, driver needs to enable interrupts that depict what is
happening on th DP/DM lines. On QUSB targets, this is identified by
typo: the
qusb2_phy whereas on SoCs using Femto PHY, separate {dp,dm}_hs_phy_irq's
are used instead.
The implementation incorrectly names qusb2_phy interrupts as "hs_phy_irq".
Clean this up so that driver would be using only qusb2/(dp & dm) for wakeup
purposes.
Here too you should say something about why this won't break any systems
booting using an older devicetree. Specifically, the QUSB2 PHY interrupt
has never been armed on any system running mainline as those bits never
made it upstream.
So an alternative to this could also be to just drop the QUSB2 PHY
interrupt handling from this driver for now. >
Hi Johan,
So, are you suggesting that we drop the whole patch ?
I assume if the older kernels are using old DT, they would be using an
old driver version too right ? Is there a case where DT is not updated
but driver is ? Because if we drop this patch from series, targets with
updated DT's would break.
Regards,
Krishna,
