On 12/6/23 13:21, Bryan O'Donoghue wrote: > On 06/12/2023 20:46, Randy Dunlap wrote: >> >> >> On 12/6/23 10:49, Guenter Roeck wrote: >>> On Wed, Dec 06, 2023 at 09:20:37AM -0800, Randy Dunlap wrote: >>>> DRM_AUX_BRIDGE depends on CONFIG_OF, so that is also needed here >>>> to fix a kconfig warning: >>>> >>>> WARNING: unmet direct dependencies detected for DRM_AUX_HPD_BRIDGE >>>> Depends on [n]: HAS_IOMEM [=y] && DRM_BRIDGE [=y] && OF [=n] >>>> Selected by [y]: >>>> - TYPEC_QCOM_PMIC [=y] && USB_SUPPORT [=y] && TYPEC [=y] && TYPEC_TCPM [=y] && (ARCH_QCOM || COMPILE_TEST [=y]) && (DRM [=y] || DRM [=y]=n) && DRM_BRIDGE [=y] >>>> >>> >>> All but impossible for me to determine if this patch or >>> https://lore.kernel.org/all/20231205-drm_aux_bridge-fixes-v1-2-d242a0ae9df4@xxxxxxxxxx/ >>> is more appropriate. >>> >>> Guenter >> >> I guess that Bryan is the person to ask about that. >> >> I don't see anything wrong with Nathan's patch. It should clear up the kconfig warning, >> so as long as it builds cleanly, it seems OK. >> > > So, I see both versions of this fix > > Nathan's > drivers/gpu/drm/renesas/rcar-du/Kconfig No, please see https://lore.kernel.org/all/20231205-drm_aux_bridge-fixes-v1-2-d242a0ae9df4@xxxxxxxxxx/ > > Yours > drivers/gpu/drm/tve200/Kconfig No, please see https://lore.kernel.org/linux-usb/a058827a-b025-4ee5-b2a4-d6c8963a6b73@xxxxxxxxxx/T/#m034fb56a750522f18813642259b18bb4867ceb46 > > and virtually equivalent commit text. I think we agree its 1:1 > > So, maybe stick with Nathan's since he posted first. Sure, I'm OK with that. -- ~Randy
