On 12/6/23 10:49, Guenter Roeck wrote: > On Wed, Dec 06, 2023 at 09:20:37AM -0800, Randy Dunlap wrote: >> DRM_AUX_BRIDGE depends on CONFIG_OF, so that is also needed here >> to fix a kconfig warning: >> >> WARNING: unmet direct dependencies detected for DRM_AUX_HPD_BRIDGE >> Depends on [n]: HAS_IOMEM [=y] && DRM_BRIDGE [=y] && OF [=n] >> Selected by [y]: >> - TYPEC_QCOM_PMIC [=y] && USB_SUPPORT [=y] && TYPEC [=y] && TYPEC_TCPM [=y] && (ARCH_QCOM || COMPILE_TEST [=y]) && (DRM [=y] || DRM [=y]=n) && DRM_BRIDGE [=y] >> > > All but impossible for me to determine if this patch or > https://lore.kernel.org/all/20231205-drm_aux_bridge-fixes-v1-2-d242a0ae9df4@xxxxxxxxxx/ > is more appropriate. > > Guenter I guess that Bryan is the person to ask about that. I don't see anything wrong with Nathan's patch. It should clear up the kconfig warning, so as long as it builds cleanly, it seems OK. > >> Fixes: 7d9f1b72b296 ("usb: typec: qcom-pmic-typec: switch to DRM_AUX_HPD_BRIDGE") >> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> >> Cc: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> >> Cc: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx> >> Cc: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx> >> Cc: Guenter Roeck <linux@xxxxxxxxxxxx> >> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> >> Cc: linux-arm-msm@xxxxxxxxxxxxxxx >> Cc: linux-usb@xxxxxxxxxxxxxxx >> Cc: Arnd Bergmann <arnd@xxxxxxxx> >> --- >> drivers/usb/typec/tcpm/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff -- a/drivers/usb/typec/tcpm/Kconfig b/drivers/usb/typec/tcpm/Kconfig >> --- a/drivers/usb/typec/tcpm/Kconfig >> +++ b/drivers/usb/typec/tcpm/Kconfig >> @@ -80,6 +80,7 @@ config TYPEC_QCOM_PMIC >> tristate "Qualcomm PMIC USB Type-C Port Controller Manager driver" >> depends on ARCH_QCOM || COMPILE_TEST >> depends on DRM || DRM=n >> + depends on OF >> select DRM_AUX_HPD_BRIDGE if DRM_BRIDGE >> help >> A Type-C port and Power Delivery driver which aggregates two -- ~Randy
