Re: [PATCH 08/19] xhci: dbc: Use sizeof_field() where it makes sense

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2.12.2023 17.50, David Laight wrote:
From: Andy Shevchenko
Sent: 01 December 2023 19:08

On Fri, Dec 01, 2023 at 05:31:52PM +0000, David Laight wrote:
From: Mathias Nyman
Sent: 01 December 2023 15:07

...

-	memset(dbc->eps, 0, sizeof(struct dbc_ep) * ARRAY_SIZE(dbc->eps));
+	memset(dbc->eps, 0, sizeof_field(struct xhci_dbc, eps));

Isn't that just:
	memset(dpc->eps, 0, sizeof (dpc->eps));
perhaps better written as:
	memset(&dpc->epc, 0, sizeof (dpc->eps);

Maybe...
You can send a patch, so it gets tested for regressions!

Any patch I write will conflict with v2 of this series.


I'll drop this 8/19 patch as it's just a one liner cleanup that does no
harm, but apparently doesn't really help either.

David, I'll be happy to take a patch for this from you, but still need to
run it through some testing

I'll send v2 of this series

Thanks
Mathias




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux