From: Mathias Nyman
> Sent: 01 December 2023 15:07
>
> From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
>
> Instead of doing custom calculations, use sizeof_field() macro.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> Signed-off-by: Mathias Nyman <mathias.nyman@xxxxxxxxxxxxxxx>
> ---
> drivers/usb/host/xhci-dbgcap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/xhci-dbgcap.c b/drivers/usb/host/xhci-dbgcap.c
> index 779a564ad698..0c9fd61e9c5b 100644
> --- a/drivers/usb/host/xhci-dbgcap.c
> +++ b/drivers/usb/host/xhci-dbgcap.c
> @@ -374,7 +374,7 @@ static void xhci_dbc_eps_init(struct xhci_dbc *dbc)
>
> static void xhci_dbc_eps_exit(struct xhci_dbc *dbc)
> {
> - memset(dbc->eps, 0, sizeof(struct dbc_ep) * ARRAY_SIZE(dbc->eps));
> + memset(dbc->eps, 0, sizeof_field(struct xhci_dbc, eps));
Isn't that just:
memset(dpc->eps, 0, sizeof (dpc->eps));
perhaps better written as:
memset(&dpc->epc, 0, sizeof (dpc->eps);
Otherwise the existing code wouldn't make sense at all.
David
> }
>
> static int dbc_erst_alloc(struct device *dev, struct xhci_ring *evt_ring,
> --
> 2.25.1
>
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
