Théo Lebrun <theo.lebrun@xxxxxxxxxxx> writes: > Hi, > > Suspend on the TI J7200 platform is broken currently. There are two > components that need to be patched so that they assume reset on > resume: (1) the TI wrapper cdns3-ti & (2) the HOST role of the > controller. > > About (1): the TI wrapper only did its hardware configuration at probe > time. Update so that it is done at resume on J7200 SoC. > > About (2): signal from cdns3-ti to cdns3 host to xHCI that the > controller resets on resume. This way we avoid the following warning: > > xhci-hcd xhci-hcd.1.auto: xHC error in resume, USBSTS 0x401, Reinit > > Strictly speaking (2) is not required to have working suspend on J7200; > its only goal is to silence this warning. > > Those patches have been tested on the TI J7200 EVM GP. No need to > mention that other patches are required for S2R to work, but those will > be sent later down the road. Those USB patches are rather standalone. > > Thanks, > Théo > > -- > Théo Lebrun, Bootlin > Embedded Linux and Kernel engineering > https://bootlin.com > > Signed-off-by: Théo Lebrun <theo.lebrun@xxxxxxxxxxx> > --- > Changes in v2: > - Remove runtime PM from cdns3-ti; it brings nothing. That means our > cdns3-ti suspend/resume patch is simpler; there is no need to handle > runtime PM at suspend/resume. Sorry I sent comments on v2 before I noticed v3 was out, but this is not a good idea IMO. I sent more detailed comment on that specific patch. Kevin
