On Sat, Oct 28, 2023 at 02:02:37PM +0700, Bagas Sanjaya wrote:
> On Fri, Oct 27, 2023 at 08:28:04PM +0300, LihaSika wrote:
> > Change lower bcdDevice value for "Super Top USB 2.0 SATA BRIDGE" to match
> > 1.50. I have such an older device with bcdDevice=1.50 and it will not work
> > otherwise.
>
> What about below description?
>
> ```
> Some old USB hard drives using Super Top USB 2.0 SATA bridge have lower
> minimum bcdDevice value than currently allowed (1.60). Such devices
> cannot be used by ums-cypress driver since their bcdDevice is out of range.
>
> Lower minimum bcdDevice to fix that.
> ```
>
> >
> > Cc: stable@xxxxxxxxxxxxxxx
> > Signed-off-by: Liha Sikanen <lihasika@xxxxxxxxx>
>
> Is your intended author name in your From: header or Signed-off-by: trailer?
>
> Also, don't forget to add Fixes: tag; that is:
>
> Fixes: a9c143c82608 ("usb-storage: restrict bcdDevice range for Super Top in Cypress ATACB")
>
> When above reviews are addressed, resend as v2. Make sure that the patch
> subject begins with `[PATCH v2]`.
There's no need, I can take this as-is, thanks.
greg k-h
