On Fri, Oct 27, 2023 at 08:28:04PM +0300, LihaSika wrote:
> Change lower bcdDevice value for "Super Top USB 2.0 SATA BRIDGE" to match
> 1.50. I have such an older device with bcdDevice=1.50 and it will not work
> otherwise.
What about below description?
```
Some old USB hard drives using Super Top USB 2.0 SATA bridge have lower
minimum bcdDevice value than currently allowed (1.60). Such devices
cannot be used by ums-cypress driver since their bcdDevice is out of range.
Lower minimum bcdDevice to fix that.
```
>
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Liha Sikanen <lihasika@xxxxxxxxx>
Is your intended author name in your From: header or Signed-off-by: trailer?
Also, don't forget to add Fixes: tag; that is:
Fixes: a9c143c82608 ("usb-storage: restrict bcdDevice range for Super Top in Cypress ATACB")
When above reviews are addressed, resend as v2. Make sure that the patch
subject begins with `[PATCH v2]`.
> ---
>
> diff --git a/drivers/usb/storage/unusual_cypress.h b/drivers/usb/storage/unusual_cypress.h
> index 0547daf..5df4075 100644
> --- a/drivers/usb/storage/unusual_cypress.h
> +++ b/drivers/usb/storage/unusual_cypress.h
> @@ -19,7 +19,7 @@ UNUSUAL_DEV( 0x04b4, 0x6831, 0x0000, 0x9999,
> "Cypress ISD-300LP",
> USB_SC_CYP_ATACB, USB_PR_DEVICE, NULL, 0),
>
> -UNUSUAL_DEV( 0x14cd, 0x6116, 0x0160, 0x0160,
> +UNUSUAL_DEV( 0x14cd, 0x6116, 0x0150, 0x0160,
> "Super Top",
> "USB 2.0 SATA BRIDGE",
> USB_SC_CYP_ATACB, USB_PR_DEVICE, NULL, 0),
>
The diff itself is LGTM.
Thanks.
--
An old man doll... just what I always wanted! - Clara
Attachment:
signature.asc
Description: PGP signature
