Hi Duje,
thanks for your patch!
On Tue, Sep 26, 2023 at 5:46 PM Duje Mihanović <duje.mihanovic@xxxxxxxx> wrote:
> Sharp's Spitz board still uses the legacy GPIO interface for configuring
> its two onboard LEDs.
>
> Convert them to use the GPIO descriptor interface.
>
> Signed-off-by: Duje Mihanović <duje.mihanovic@xxxxxxxx>
(...)
> +static struct gpiod_lookup_table spitz_led_gpio_table = {
> + .dev_id = "leds-gpio",
> + .table = {
> + GPIO_LOOKUP("pxa-gpio", SPITZ_GPIO_LED_ORANGE, "led_orange",
> + GPIO_ACTIVE_HIGH),
> + GPIO_LOOKUP("pxa-gpio", SPITZ_GPIO_LED_GREEN, "led_green",
> + GPIO_ACTIVE_HIGH),
Unfortunately this is not how leds-gpio works.
You have to have the name be NULL instead of "led_orange" etc, and
put the LEDs in index order, in this case something like;
+ .dev_id = "leds-gpio",
+ .table = {
+ GPIO_LOOKUP_IDX("pxa-gpio", SPITZ_GPIO_LED_ORANGE,
NULL, 0, GPIO_ACTIVE_HIGH),
+ GPIO_LOOKUP_IDX("pxa-gpio", SPITZ_GPIO_LED_GREEN,
NULL, 1, GPIO_ACTIVE_HIGH),
Yours,
Linus Walleij
