On Tue, Sep 26, 2023 at 05:46:22PM +0200, Duje Mihanović wrote: > Sharp's Spitz board still uses the legacy GPIO interface for controlling > a GPIO pin related to the USB host controller. > > Convert this function to use the new GPIO descriptor interface. ... > + pxa_ohci->usb_host = gpiod_get_optional(&pdev->dev, "usb-host", GPIOD_OUT_LOW); > + if (IS_ERR(pxa_ohci->usb_host)) > + dev_warn(&pdev->dev, "failed to get USB host GPIO with %pe\n", > + pxa_ohci->usb_host); No, with _optional() you should terminate the execution and bail out. The idea behind *optional* is that we skip errors only for the cases when GPIO is not provided. Otherwise we need to handle the errors (yes, the dev_err() has to be used). -- With Best Regards, Andy Shevchenko
