On Mon, Sep 25, 2023 at 03:54:40PM +0000, Patel, Utkarsh H wrote: ... > > > + /** > > > > Are you sure? > > > > > + * Get cable VDO for thunderbolt cables and cables with DPSID but > > does not > > > + * support DPAM2.1. > > > + */ > > > Yes, there are TBT3 cables which advertise DPSID but does not provide any DP > capabilities in the DP discover mode VDO but does support UHBR. In that > case, need to use TBTSID and use capabilities from TBT discover mode VDO. My comment was against the style of the comment, not about content. ... > > You can also make it a bit more readable with (use better names if you think it's > > needed) > > > > u32 signalling = 0; > > u32 cable_type = 0; > > In v2 version of this patch I had them but there was feedback to remove extra > variables and use them inline. OK! -- With Best Regards, Andy Shevchenko
