On 9/19/23 14:16, Michael Grzeschik wrote: > On Tue, Sep 19, 2023 at 01:22:42PM -0700, Avichal Rakesh wrote: >> >> >> On 9/19/23 13:07, Michael Grzeschik wrote: >>> On Tue, Sep 19, 2023 at 12:55:02PM -0700, Avichal Rakesh wrote: >>>> On 9/19/23 12:13, Michael Grzeschik wrote: >>>>> On Mon, Sep 18, 2023 at 04:40:07PM -0700, Avichal Rakesh wrote: >>>>>> >>>>>> >>>>>> On 9/18/23 14:43, Michael Grzeschik wrote: >>>>>>> On Mon, Sep 18, 2023 at 12:02:11PM -0700, Avichal Rakesh wrote: >>>>>>>> On 9/16/23 16:23, Michael Grzeschik wrote: >>>>>>>>> On Fri, Sep 15, 2023 at 07:41:05PM -0700, Avichal Rakesh wrote: >>>>>>>>>> On 9/15/23 16:32, Michael Grzeschik wrote: >>>>>>>>>>> On Mon, Sep 11, 2023 at 09:52:22PM -0700, Avichal Rakesh wrote: >>>>>>>>>>>> On 9/10/23 17:24, Michael Grzeschik wrote: >>>>>>>>>>>>> The uvc_video_enable function of the uvc-gadget driver is dequeing and >>>>>>>>>>>>> immediately deallocs all requests on its disable codepath. This is not >>>>>>>>>>>>> save since the dequeue function is async and does not ensure that the >>>>>>>>>>>>> requests are left unlinked in the controller driver. >>>>>>>>>>>>> >>>>>>>>>>>>> <snip> >> >> Agreed, uvc_video_free_requests should only free the requests in >> req_free. >> >> Just to clear any confusion: are you working on incorporating these changes >> into your patchset, or do you want me to include them in >> https://lore.kernel.org/20230912041910.726442-3-arakesh@xxxxxxxxxx/ >> instead? > > As I am busy on a different topic at the moment, and you have suggested > the main walkthrough for the solution, it would be great if you could > come up with the proper patch. > > But it would be great to find my Suggested-by in the patches. :) Just sent out https://lore.kernel.org/20230920200335.63709-1-arakesh@xxxxxxxxxx with the changes discussed in this thread. The patch should work without requiring any changes to dwc3. I didn't run into any crashes when testing the changes locally, but if you can, I'd appreciate you testing the patches on your crash-prone setup as my setup's crash rate was pretty low to begin with. Thank you! - Avi.
