On Sat, Aug 26, 2023 at 09:40:20AM +0200, Greg KH wrote: > On Fri, Aug 25, 2023 at 09:04:29PM +0000, Patel, Utkarsh H wrote: > > Hi Greg, > > > > > > > > > > > > > > We are only calling it once depending upon which mode we enter TBT > > > > > > Alt or > > > > > USB4. > > > > > > > > > > There should only be 1 "call site" and that should be sufficient to > > > > > grab the VDO from the framework for all circumstances. Whether the > > > > > other invocation doesn't get called under certain circumstances isn't as > > > relevant. > > > > > > > > Are you suggesting something like this? > > > > > > > > static int cros_typec_configure_mux(struct cros_typec_data *typec, int > > > port_num,)... > > > > > > > > if (port->mux_flags & USB_PD_MUX_USB4_ENABLED || > > > > port->mux_flags & USB_PD_MUX_TBT_COMPAT_ENABLED) > > > > cable_tbt_vdo = cros_typec_get_cable_vdo(port, > > > USB_TYPEC_TBT_SID); > > > > > > My apologies, I misread the patch. I think this looks good. > > > > > > Acked-by: Prashant Malani <pmalani@xxxxxxxxxxxx> > > > > Could you please add this patch to usb-next. > > Ugh, it's late in the cycle, but this has been around for a while, let > me go see... Looks like patch 2/2 was already in my tree, so I've queued up this one now as well. thanks, greg k-h
