Hi Utkarsh, On Aug 22 21:21, Patel, Utkarsh H wrote: > Hi Prashant, > > > -----Original Message----- > > From: Prashant Malani <pmalani@xxxxxxxxxxxx> > > Sent: Monday, August 21, 2023 4:31 PM > > > > > > We are only calling it once depending upon which mode we enter TBT Alt or > > USB4. > > > > There should only be 1 "call site" and that should be sufficient to grab the VDO > > from the framework for all circumstances. Whether the other invocation > > doesn't get called under certain circumstances isn't as relevant. > > Are you suggesting something like this? > > static int cros_typec_configure_mux(struct cros_typec_data *typec, int port_num,)... > > if (port->mux_flags & USB_PD_MUX_USB4_ENABLED || > port->mux_flags & USB_PD_MUX_TBT_COMPAT_ENABLED) > cable_tbt_vdo = cros_typec_get_cable_vdo(port, USB_TYPEC_TBT_SID); My apologies, I misread the patch. I think this looks good. Acked-by: Prashant Malani <pmalani@xxxxxxxxxxxx>
