Hi, > -----Original Message----- > From: Felipe Balbi [mailto:felipe.balbi@xxxxxxxxx] > Sent: Tuesday, November 24, 2009 6:25 PM > To: Gupta, Ajay Kumar > Cc: Balbi Felipe (Nokia-D/Helsinki); linux-usb@xxxxxxxxxxxxxxx; Gadiyar, > Anand > Subject: Re: [PATCH 1/2] musb: Add context save and restore support > > Hi, > > On Tue, Nov 24, 2009 at 01:44:44PM +0100, ext Gupta, Ajay Kumar wrote: > >> > static int musb_suspend(struct device *dev) > >> > { > >> > >> what I would like to see (this is for omap pm guys now) is that omap > >> uses pm_runtime.h and pm_qos.h. It would also be nice to add a PM_OFF > to > >> pm_message_t so that we know when we're transitioning to off mode. Then > >> based on PM_OFF we would save context. > > > >Is it only OMAP3 specific ? Does other musb platform would support such > >Changes? > > what we have today is omap3 (and onwards) specific. I'm pretty sure > there are plenty of other platforms that won't support runtime off mode. > > if we have the omap3 stuff using what the kernel already gives us, then > we could kick context save/restore based on the pm_message_t we are > receiving :-). > > Currently we are always saving context when entering suspend which might > not be necessary at all. > > If we support pm_runtime.h methods, other platforms might support it as > well, for sure. They would just need to provide the function pointers. > But currently (not seen here yet) with all of those omap3 only functions > from the shared resource fw, we will have to rape musb's platform_data > to pass those function pointers; simply because omap decided to do > differently, right ? > > But I guess this is just a thought, doesn't need to be taken into > account right now although we need to keep it in mind ;-) Ok fine. I will resubmit the patch with suggested change for now. Thanks, Ajay > > -- > balbi -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
