Hi Rob, > > + > > +examples: > > + - | > > + usb@98013e00 { > > + compatible = "realtek,rtd1319d-dwc3", "realtek,rtd-dwc3"; > > + reg = <0x98013e00 0x200>; > > + #address-cells = <1>; > > + #size-cells = <1>; > > + ranges; > > + maximum-speed = "high-speed"; > > This should be a warning (the bot was having problems) as it is not defined for > this node. It belongs in the child node as you also have, so drop it. As I mentioned in the v1 patch, I have a problem. This property maximum-speed belongs to dwc3. When the dwc3-rtk setting disables USB 3.0 phy, dwc3 is not probed. So I can't use api usb_get_maximum_speed(dev) to get maximum-speed. I added this property "maximum-speed" to the dwc3-rtk node, which is the same as the dwc3 core node. Is this configuration appropriate? Or do you have any suggestion? > > + > > + usb@98050000 { > > + compatible = "snps,dwc3"; > > + reg = <0x98050000 0x9000>; > > + interrupts = <0 94 4>; > > + phys = <&usb2phy &usb3phy>; > > + phy-names = "usb2-phy", "usb3-phy"; > > + dr_mode = "otg"; > > + usb-role-switch; > > + role-switch-default-mode = "host"; > > + snps,dis_u2_susphy_quirk; > > + snps,parkmode-disable-ss-quirk; > > + snps,parkmode-disable-hs-quirk; > > + maximum-speed = "high-speed"; > > + }; > > + }; > > -- > > 2.34.1 > > Thanks, Stanley