On 8/3/2023 2:56 PM, Oliver Neukum wrote:
Hi, On 03.08.23 07:18, Linyu Yuan wrote:In function ecm_bitrate(), it is not good to report same speed as super speed when gadget work at super speed plus. Change report speed same as commit 986499b1569a ("usb: gadget: f_ncm: fix ncm_bitrate for SuperSpeed and above.").this is very well, but it raises two questions. 1. What is the relation to decreasing the usage of gadget_is_* This patch increases it. And why? Why not use raw speed?
i will move this change at end of series, maybe better.
2. Code like this is used in multiple gadget drivers. Couldn't this be unified into a macro or something?
sure, will try it.
Regards Oliver
