Re: [PATCH 1/7] usb: gadget: f_ecm: fix ecm_bitrate() for SuperSpeed and above

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 03.08.23 07:18, Linyu Yuan wrote:
In function ecm_bitrate(), it is not good to report same speed as
super speed when gadget work at super speed plus.

Change report speed same as commit 986499b1569a ("usb: gadget: f_ncm:
fix ncm_bitrate for SuperSpeed and above.").

this is very well, but it raises two questions.

1. What is the relation to decreasing the usage of gadget_is_*
This patch increases it. And why? Why not use raw speed?

2. Code like this is used in multiple gadget drivers.
Couldn't this be unified into a macro or something?

	Regards
		Oliver




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux