Re: [PATCH -next] usb: host: Do not check for 0 return after calling platform_get_irq()

[Justin Chen <justin.chen@xxxxxxxxxxxx>]

On 8/1/23 8:12 PM, Ruan Jinjie wrote:
> It is not possible for platform_get_irq() to return 0. Use the
> return value from platform_get_irq().
>
> Signed-off-by: Ruan Jinjie <ruanjinjie@xxxxxxxxxx>
> ---
>   drivers/usb/host/ehci-atmel.c | 4 ++--
>   drivers/usb/host/ehci-brcm.c  | 4 ++--

Reviewed-by: Justin Chen <justin.chen@xxxxxxxxxxxx>

>   drivers/usb/host/ehci-orion.c | 4 ++--
>   drivers/usb/host/ehci-sh.c    | 4 ++--
>   4 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/usb/host/ehci-atmel.c b/drivers/usb/host/ehci-atmel.c
> index 61808c51e702..6ee08476afd9 100644
> --- a/drivers/usb/host/ehci-atmel.c
> +++ b/drivers/usb/host/ehci-atmel.c
> @@ -102,8 +102,8 @@ static int ehci_atmel_drv_probe(struct platform_device *pdev)
>   	pr_debug("Initializing Atmel-SoC USB Host Controller\n");
>   
>   	irq = platform_get_irq(pdev, 0);
> -	if (irq <= 0) {
> -		retval = -ENODEV;
> +	if (irq < 0) {
> +		retval = irq;
>   		goto fail_create_hcd;
>   	}
>   
> diff --git a/drivers/usb/host/ehci-brcm.c b/drivers/usb/host/ehci-brcm.c
> index 0362a082abb4..77e42c739c58 100644
> --- a/drivers/usb/host/ehci-brcm.c
> +++ b/drivers/usb/host/ehci-brcm.c
> @@ -140,8 +140,8 @@ static int ehci_brcm_probe(struct platform_device *pdev)
>   		return err;
>   
>   	irq = platform_get_irq(pdev, 0);
> -	if (irq <= 0)
> -		return irq ? irq : -EINVAL;
> +	if (irq < 0)
> +		return irq;
>   
>   	/* Hook the hub control routine to work around a bug */
>   	ehci_brcm_hc_driver.hub_control = ehci_brcm_hub_control;
> diff --git a/drivers/usb/host/ehci-orion.c b/drivers/usb/host/ehci-orion.c
> index 2cfb27dc943a..a4663351ba26 100644
> --- a/drivers/usb/host/ehci-orion.c
> +++ b/drivers/usb/host/ehci-orion.c
> @@ -220,8 +220,8 @@ static int ehci_orion_drv_probe(struct platform_device *pdev)
>   	pr_debug("Initializing Orion-SoC USB Host Controller\n");
>   
>   	irq = platform_get_irq(pdev, 0);
> -	if (irq <= 0) {
> -		err = -ENODEV;
> +	if (irq < 0) {
> +		err = irq;
>   		goto err;
>   	}
>   
> diff --git a/drivers/usb/host/ehci-sh.c b/drivers/usb/host/ehci-sh.c
> index 0520e762801d..f982c236e187 100644
> --- a/drivers/usb/host/ehci-sh.c
> +++ b/drivers/usb/host/ehci-sh.c
> @@ -82,8 +82,8 @@ static int ehci_hcd_sh_probe(struct platform_device *pdev)
>   		return -ENODEV;
>   
>   	irq = platform_get_irq(pdev, 0);
> -	if (irq <= 0) {
> -		ret = -ENODEV;
> +	if (irq < 0) {
> +		ret = irq;
>   		goto fail_create_hcd;
>   	}
>

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature