Re: [PATCH 1/4] MUSB: Populate the VBUS GPIO with the correct GPIO number

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello.

Gupta, Ajay Kumar wrote:

-----Original Message-----
From: linux-usb-owner@xxxxxxxxxxxxxxx [mailto:linux-usb-
owner@xxxxxxxxxxxxxxx] On Behalf Of Gadiyar, Anand
Sent: Saturday, November 21, 2009 3:46 PM
To: linux-usb@xxxxxxxxxxxxxxx; Greg KH
Cc: Subbrathnam, Swaminathan; David Brownell; Sergei Shtylyov
Subject: [PATCH 1/4] MUSB: Populate the VBUS GPIO with the correct GPIO
number

From: Swaminathan S <swami.iyer@xxxxxx>

MUSB: Populate the VBUS GPIO with the correct GPIO number

Signed-off-by: Swaminathan S <swami.iyer@xxxxxx>
Cc: David Brownell <dbrownell@xxxxxxxxxxxxxxxxxxxxx>
Cc: Sergei Shtylyov <sshtylyov@xxxxxxxxxxxxx>
Acked-by: Anand Gadiyar <gadiyar@xxxxxx>
---
Sergei tested this and reported it working. This is needed
since the TI DA8xx support was merged in .32-rc2
This fixes a null-pointer dereference bug in Linus' tree.

Waiting for a Tested-by/Ack from Sergei, but as far as I can
tell, this is a valid fix.

There is a cleaner fix for this in generic way where all boards would
Pass on the GPIO numbers. It's available in Swaminathan's patchset.
Submitted earlier and need a refresh and some rework.


I've never seen this patchset anmd I'm afraid it's more of -rc1 material than a fix for this urgent issue. We bascailly have not time left for any rework at this pont, when -rc8 is out, we need to fix the issue ASAP, before 2.6.32 is released.

I will post them so please drop this one.

  When?

Regards,
Ajay
 drivers/usb/musb/davinci.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/usb/musb/davinci.c b/drivers/usb/musb/davinci.c
index e16ff60..6691381 100644
--- a/drivers/usb/musb/davinci.c
+++ b/drivers/usb/musb/davinci.c
@@ -42,7 +42,7 @@
 #include "musb_core.h"

 #ifdef CONFIG_MACH_DAVINCI_EVM
-#define GPIO_nVBUS_DRV		144
+#define GPIO_nVBUS_DRV		160
 #endif

 #include "davinci.h"
--
1.6.0.rc1.64.g61192

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WBR, Sergei


--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux