On Mon, Jul 3, 2023 at 2:19 PM Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > Use read_poll_timeout() instead of open coding it. > In the same time, fix the typo in the error message. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> (...) > + ret = read_poll_timeout(gpiod_get_value, reg, !reg, 1000, 100000, true, > + glue->intpin); Wow that's really cool. I had no idea that you could use read_poll_timeout() together with gpiod_get_value() like this! Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx> Yours, Linus Walleij