On Thu, Nov 12, 2009 at 04:56:44PM -0500, Nathaniel McCallum wrote: > I've uncovered two bugs in USB modalias generation (file2alias.c). > Patches are attached for both. You can see my original post (I forgot > to CC linux-usb) here: http://lkml.org/lkml/2009/11/11/245 > > The first is when a device ignores the USB spec and specifies bcdDevice > in hex rather than BCD format. This forces the driver to match against > a hex formatted bcdDevice (see ibmcam for an example). The end result > is that file2alias generates an invalid modalias (ex. d000[10-9]). The > patch detects when a driver uses a hex formatted bcdDevice_(lo|hi) and > adjusts the output to hex format accordingly. > > The second bug is when incrementing/decrementing on a BCD formatted > integer (i.e. 0x09++ should be 0x10 not 0x0A). This patch just adds a > function for incrementing/decrementing BCD integers by converting to > decimal, doing the increment/decrement and then converting back to BCD. > > Questions/comments welcome. Ok, these look reasonable, given your other emails about this. Care to resend these, with proper changelog and signed-off-by lines, one per email, so I can apply them to the tree? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
