Re: [PATCH] USB: serial: option: add u-blox LARA-R6 01B modem

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jun 21, 2023 at 10:47:30AM +0200, Davide Tronchin wrote:
> > Can you please also include the output of usb-devices for these
> > configurations?
> 
> The first 4 interfaces of all the 3 configurations (default, RMNET, ECM)
> are the same.
> Here below you can find debug/usb/devices file of the LARA-R6 01B module
> in all the USB configurations.

Thanks, can you include this in the commit message for v2 as well?

> ECM:
> T:  Bus=01 Lev=02 Prnt=02 Port=02 Cnt=02 Dev#=  9 Spd=480  MxCh= 0
> D:  Ver= 2.00 Cls=ef(misc ) Sub=02 Prot=01 MxPS=64 #Cfgs=  1
> P:  Vendor=1546 ProdID=1313 Rev= 0.00
> S:  Manufacturer=u-blox
> S:  Product=u-blox Modem
> S:  SerialNumber=1478200b
> C:* #Ifs= 6 Cfg#= 1 Atr=e0 MxPwr=500mA
> A:  FirstIf#= 4 IfCount= 2 Cls=02(comm.) Sub=00 Prot=00
> I:* If#= 0 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=30 Driver=option
> E:  Ad=81(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> E:  Ad=01(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> I:* If#= 1 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=ff Driver=option
> E:  Ad=82(I) Atr=03(Int.) MxPS=  64 Ivl=2ms
> E:  Ad=83(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> E:  Ad=02(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> I:* If#= 2 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=ff Driver=option
> E:  Ad=84(I) Atr=03(Int.) MxPS=  64 Ivl=2ms
> E:  Ad=85(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> E:  Ad=03(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> I:* If#= 3 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=ff Driver=option
> E:  Ad=86(I) Atr=03(Int.) MxPS=  64 Ivl=2ms
> E:  Ad=87(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> E:  Ad=04(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> I:* If#= 4 Alt= 0 #EPs= 1 Cls=02(comm.) Sub=06 Prot=00 Driver=cdc_ether
> E:  Ad=88(I) Atr=03(Int.) MxPS=  64 Ivl=2ms
> I:  If#= 5 Alt= 0 #EPs= 0 Cls=0a(data ) Sub=00 Prot=00 Driver=cdc_ether
> I:* If#= 5 Alt= 1 #EPs= 2 Cls=0a(data ) Sub=00 Prot=00 Driver=cdc_ether
> E:  Ad=89(I) Atr=02(Bulk) MxPS= 512 Ivl=0ms
> E:  Ad=05(O) Atr=02(Bulk) MxPS= 512 Ivl=0ms

> > I see that we used RSVD() also for the CDC interface for LARA-L6, but
> > shouldn't it be possible to use a more exact match instead? The
> > usb-devices output should tell.
> 
> Probably USB_DEVICE_AND_INTERFACE_INFO would not match LARA-R6 01B
> serial composition since R6 01B has:
> - Diagnostic
>     Cls=ff(vend.) Sub=ff Prot=30
> - all the other serial interfaces
>     Cls=ff(vend.) Sub=ff Prot=ff
> Could you kindly offer any recommendations?
> Maybe USB_DEVICE_INTERFACE_CLASS ca be used instead of
> USB_DEVICE_AND_INTERFACE_INFO.

Right, I had USB_DEVICE_INTERFACE_CLASS() in mind for the ECM
configuration. That should avoid the need for RSVD().

Johan



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux