On Tue, Jun 13, 2023 at 04:14:41PM +0200, Davide Tronchin wrote:
> The new LARA-R6 product variant identified by the "01B" string can be
> configured (by AT interface) in three different USB modes:
> * Default mode (Vendor ID: 0x1546 Product ID: 0x1311) with 4 serial
> interfaces
> * RmNet mode (Vendor ID: 0x1546 Product ID: 0x1312) with 4 serial
> interfaces and 1 RmNet virtual network interface
> * CDC-ECM mode (Vendor ID: 0x1546 Product ID: 0x1313) with 4 serial
> interface and 1 CDC-ECM virtual network interface
>
> In default mode LARA-R6 01B exposes the following interfaces:
> If 0: Diagnostic
> If 1: AT parser
> If 2: AT parser
> If 3: AT parser/alternative functions
>
> In RmNet mode LARA-R6 01B exposes the following interfaces:
> If 0: Diagnostic
> If 1: AT parser
> If 2: AT parser
> If 3: AT parser/alternative functions
> If 4: RMNET interface
>
> In CDC-ECM mode LARA-R6 01B exposes the following interfaces:
> If 0: Diagnostic
> If 1: AT parser
> If 2: AT parser
> If 3: AT parser/alternative functions
> If 4: CDC-ECM interface
Can you please also include the output of usb-devices for these
configurations?
> Signed-off-by: Davide Tronchin <davide.tronchin.94@xxxxxxxxx>
>
> ---
> drivers/usb/serial/option.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
> index 644a55447fd7..5b684b6f5969 100644
> --- a/drivers/usb/serial/option.c
> +++ b/drivers/usb/serial/option.c
> @@ -1152,6 +1152,11 @@ static const struct usb_device_id option_ids[] = {
> .driver_info = RSVD(4) },
> { USB_DEVICE(UBLOX_VENDOR_ID, 0x1343), /* u-blox LARA-L6 (ECM) */
> .driver_info = RSVD(4) },
> + { USB_DEVICE(UBLOX_VENDOR_ID, 0x1311) }, /* u-blox LARA-R6 01B */
> + { USB_DEVICE(UBLOX_VENDOR_ID, 0x1312), /* u-blox LARA-R6 01B (RMNET) */
> + .driver_info = RSVD(4) },
> + { USB_DEVICE(UBLOX_VENDOR_ID, 0x1313), /* u-blox LARA-R6 01B (ECM) */
> + .driver_info = RSVD(4) },
These should all go above the 0x1341 PID.
I see that we used RSVD() also for the CDC interface for LARA-L6, but
shouldn't it be possible to use a more exact match instead? The
usb-devices output should tell.
> /* Quectel products using Quectel vendor ID */
> { USB_DEVICE_AND_INTERFACE_INFO(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_EC21, 0xff, 0xff, 0xff),
> .driver_info = NUMEP2 },
Johan
