Hi, On Sat, 2023-05-27 at 15:03 +0200, Foster Snowhill wrote: > From: Georgi Valkov <gvalkov@xxxxxxxxx> > > The cleanup precedure in ipheth_probe will attempt to free a > NULL pointer in dev->ctrl_buf if the memory allocation for > this buffer is not successful. While kfree ignores NULL pointers, > and the existing code is safe, it is a better design to rearrange > the goto labels and avoid this. > > Signed-off-by: Georgi Valkov <gvalkov@xxxxxxxxx> > Signed-off-by: Foster Snowhill <forst@xxxxxx> If you are going to repost (due to changes in patch 2) please update this patch subj, too. Currently is a bit confusing, something alike "cleanup the initialization error path" would be more clear. Thanks, Paolo
