On Sat, May 27, 2023 at 03:03:08PM +0200, Foster Snowhill wrote: > From: Georgi Valkov <gvalkov@xxxxxxxxx> > > The cleanup precedure in ipheth_probe will attempt to free a > NULL pointer in dev->ctrl_buf if the memory allocation for > this buffer is not successful. While kfree ignores NULL pointers, > and the existing code is safe, it is a better design to rearrange > the goto labels and avoid this. > > Signed-off-by: Georgi Valkov <gvalkov@xxxxxxxxx> > Signed-off-by: Foster Snowhill <forst@xxxxxx> Reviewed-by: Simon Horman <simon.horman@xxxxxxxxxxxx>
