On 2023/5/3 4:08, Krzysztof Kozlowski wrote: > On 02/05/2023 10:18, Minda Chen wrote: >> To support generic clock and reset init in Cadence USBSS >> controller. Add clock and reset dts configuration. >> >> Signed-off-by: Minda Chen <minda.chen@xxxxxxxxxxxxxxxx> > > Subject prefix: dt-bindings > ok >> --- >> Documentation/devicetree/bindings/usb/cdns,usb3.yaml | 12 ++++++++++++ >> 1 file changed, 12 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/usb/cdns,usb3.yaml b/Documentation/devicetree/bindings/usb/cdns,usb3.yaml >> index cae46c4982ad..7bffd8fb1e38 100644 >> --- a/Documentation/devicetree/bindings/usb/cdns,usb3.yaml >> +++ b/Documentation/devicetree/bindings/usb/cdns,usb3.yaml >> @@ -42,6 +42,18 @@ properties: >> - const: otg >> - const: wakeup >> >> + clocks: >> + minItems: 1 > > no, this must maxItems. > ok >> + >> + clock-names: >> + minItems: 1 > > Drop entire property, not useful without descriptive name. > So I will delete clock-names and reset-names in my starfive codes. >> + >> + resets: >> + minItems: 1 > > instead maxItems. > >> + >> + reset-names: >> + minItems: 1 > > Drop entire property, not useful without descriptive name. > >> + >> dr_mode: >> enum: [host, otg, peripheral] >> > > Best regards, > Krzysztof >
