On 2023/5/3 4:10, Krzysztof Kozlowski wrote: > On 02/05/2023 10:18, Minda Chen wrote: >> To support generic clock and reset init in Cadence USBSS >> controller. Add clock and reset dts configuration. > > s/. Add/, add/ > (although still weird sentence) > ok >> >> Signed-off-by: Minda Chen <minda.chen@xxxxxxxxxxxxxxxx> >> --- >> Documentation/devicetree/bindings/usb/cdns,usb3.yaml | 12 ++++++++++++ > > Also update the example or any in-tree DTS. Why existing users do not > need it? Aren't you duplicating clocks with wrapping node? > > Best regards, > Krzysztof > I will update the example. Exiting users are NXP and TI. NXP codes do not contain clock and resets, TI usb2 refclk require to set clock rate， TI codes can't direct use it. And I don't know TI's hardware. Maybe Roger can take into account to use it.
