Re: [PATCH v1 1/6] dt-bindings: usb: qcom,dwc3: Add bindings for SA8775P

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 4/27/2023 7:52 PM, Rob Herring wrote:
On Fri, Apr 21, 2023 at 07:09:16PM +0530, Shazad Hussain wrote:
Add the compatible string for SA8775P SoC from Qualcomm.

Set minItems to 3 for interrupts as usb2 i.e third usb port supports
only high speed mode and does not require ss_phy_irq.

Signed-off-by: Shazad Hussain <quic_shazhuss@xxxxxxxxxxx>
---
  Documentation/devicetree/bindings/usb/qcom,dwc3.yaml | 5 +++++
  1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
index d84281926f10..3ae02cffae49 100644
--- a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
+++ b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
@@ -23,6 +23,7 @@ properties:
            - qcom,msm8998-dwc3
            - qcom,qcm2290-dwc3
            - qcom,qcs404-dwc3
+          - qcom,sa8775p-dwc3
            - qcom,sc7180-dwc3
            - qcom,sc7280-dwc3
            - qcom,sc8280xp-dwc3
@@ -180,6 +181,7 @@ allOf:
                - qcom,msm8953-dwc3
                - qcom,msm8996-dwc3
                - qcom,msm8998-dwc3
+              - qcom,sa8775p-dwc3
                - qcom,sc7180-dwc3
                - qcom,sc7280-dwc3
                - qcom,sdm670-dwc3
@@ -443,12 +445,15 @@ allOf:
          compatible:
            contains:
              enum:
+              - qcom,sa8775p-dwc3
                - qcom,sc8280xp-dwc3
      then:
        properties:
          interrupts:
+          minItems: 3

Now 3 interrupts is valid for qcom,sc8280xp-dwc3?


Hi Rob,
I was under the impression from [1] that usb_2 for sc8280xp has only 3
irq's, but it seems it does required all 4 irq's.
I would take care of this in next version of the patch. Thanks for
pointing it out.

[1]:
https://lore.kernel.org/lkml/20230405125759.4201-7-quic_kriskura@xxxxxxxxxxx/

            maxItems: 4
          interrupt-names:
+          minItems: 3
            items:
              - const: pwr_event
              - const: dp_hs_phy_irq
--
2.17.1

-Shazad



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux