Hi > -----Original Message----- > From: Rob Herring <robh@xxxxxxxxxx> > Sent: Wednesday, April 19, 2023 12:10 AM > To: Mehta, Piyush <piyush.mehta@xxxxxxx> > Cc: gregkh@xxxxxxxxxxxxxxxxxxx; krzysztof.kozlowski+dt@xxxxxxxxxx; > michal.simek@xxxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx; > devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Simek, Michal > <michal.simek@xxxxxxx>; Paladugu, Siva Durga Prasad > <siva.durga.prasad.paladugu@xxxxxxx>; linux-arm- > kernel@xxxxxxxxxxxxxxxxxxx; git (AMD-Xilinx) <git@xxxxxxx> > Subject: Re: [PATCH] dt-bindings: usb: dwc3: xilinx: Add interrupt-names to > include hibernation interrupt > > On Wed, Apr 12, 2023 at 11:38:43AM +0530, Piyush Mehta wrote: > > The hibernation feature enabled for Xilinx Versal NET SoC in DWC3 IP. > > Added host mode interrupts and "usb-wakeup" interrupt-names optional > > property in the binding schema to capture remote-wakeup and connect/ > > disconnect event in the hibernation state. > > > > Xilinx dwc3-core uses "host" and "otg" interrupts interrupt-names DT > > properties from dwc3-core. > > Is wakeup really not implemented in the DWC3 core, but outside it? Wakeup is implemented inside the dwc3-core. Initially we planned to implement wakeup interrupt name/interrupt optional property in the dwc3-core. However, looking at other vendor wakeup interrupt implementation (Commit: dd566faebe9f dt-bindings: usb: qcom,dwc3: refine interrupt requirements) we moved wakeup property to xilinx USB binding. > > > > > Signed-off-by: Piyush Mehta <piyush.mehta@xxxxxxx> > > --- > > Note: > > - Xilinx uses dwc3-cores interrupt-names DT property. > > Link: > > Xilinx-dwc3 core: > https://github.com/torvalds/linux/blob/master/Documentation/devicetree/bi > ndings/usb/dwc3-xilinx.yaml#L129 > > dwc3-core: > > https://github.com/torvalds/linux/blob/master/Documentation/devicetree > > /bindings/usb/snps%2Cdwc3.yaml#L42 > > --- > > Documentation/devicetree/bindings/usb/dwc3-xilinx.yaml | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/usb/dwc3-xilinx.yaml > > b/Documentation/devicetree/bindings/usb/dwc3-xilinx.yaml > > index 098b73134a1b..abc32db2448a 100644 > > --- a/Documentation/devicetree/bindings/usb/dwc3-xilinx.yaml > > +++ b/Documentation/devicetree/bindings/usb/dwc3-xilinx.yaml > > @@ -44,6 +44,15 @@ properties: > > - const: bus_clk > > - const: ref_clk > > > > + interrupts: > > + items: > > + - description: Handle to the line usb-wakeup used to wake > > + up the host processor. > > + > > + interrupt-names: > > + items: > > + - const: usb-wakeup > > 'wakeup' is the standard name. And you also need 'wakeup-source' > property. > > > + > > resets: > > description: > > A list of phandles for resets listed in reset-names. > > -- > > 2.25.1 > >
