Am Donnerstag, 12. November 2009 00:10:29 schrieb Sarah Sharp: > > --- a/drivers/usb/core/hcd.c > > > > > +++ b/drivers/usb/core/hcd.c > > > > > > > > > @@ -868,6 +869,7 @@ static void usb_bus_init (struct usb_bus *bus) > > > bus->bandwidth_allocated = 0; > > > bus->bandwidth_int_reqs = 0; > > > bus->bandwidth_isoc_reqs = 0; > > > + mutex_init(&bus->bandwidth_lock); > > > > > > I'd prefer to put the new mutex into struct usb_hcd rather than > > usb_bus. The usb_bus structure is a holdover from long ago. > > > > Also, since it is a mutex and not a spinlock, perhaps you should name > > it something other than "bandwidth_lock". > > bandwidth_mutex? Fine. :) I may be dense, but why would bandwidth be connected to either the hcd or the bus? It seems to me that you can exceed the bandwidth a hub provides long before you max the bus, by using slow or full speed devices on a high speed hub. Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
