On Fri, Mar 24, 2023 at 02:10:26PM +0800, Linyu Yuan wrote: > It prepare to improve pr_vdebug() which will show dev_name when multiple > f_fs instance exist. I am sorry, but I can not parse this. Please describe why you are doing this better next time. > > Signed-off-by: Linyu Yuan <quic_linyyuan@xxxxxxxxxxx> > --- > v2: split to several changes according to v1 comments > v1: https://lore.kernel.org/linux-usb/1679481369-30094-1-git-send-email-quic_linyyuan@xxxxxxxxxxx/ > > drivers/usb/gadget/function/f_fs.c | 78 +++++++++++++++++++------------------- > 1 file changed, 38 insertions(+), 40 deletions(-) > > diff --git a/drivers/usb/gadget/function/f_fs.c b/drivers/usb/gadget/function/f_fs.c > index 8830847..a4051c8 100644 > --- a/drivers/usb/gadget/function/f_fs.c > +++ b/drivers/usb/gadget/function/f_fs.c > @@ -231,7 +231,6 @@ struct ffs_io_data { > }; > > struct ffs_desc_helper { > - struct ffs_data *ffs; Your subject line says you are adding more function, but you are really removing the structure pointer here? Why? Shouldn't removing this pointer be a separate commit? thanks, greg k-h
