On Fri, Mar 24, 2023 at 02:10:27PM +0800, Linyu Yuan wrote: > when multiple instances in use, the debug message is hard to understand > as there is no instance name show. > > this change will show each instance name for debug messages. > > Signed-off-by: Linyu Yuan <quic_linyyuan@xxxxxxxxxxx> > --- > v2: split to several changes according to v1 comments > v1: https://lore.kernel.org/linux-usb/1679481369-30094-1-git-send-email-quic_linyyuan@xxxxxxxxxxx/ > > drivers/usb/gadget/function/f_fs.c | 136 +++++++++++++++++++------------------ > 1 file changed, 69 insertions(+), 67 deletions(-) > > diff --git a/drivers/usb/gadget/function/f_fs.c b/drivers/usb/gadget/function/f_fs.c > index a4051c8..df67ab5 100644 > --- a/drivers/usb/gadget/function/f_fs.c > +++ b/drivers/usb/gadget/function/f_fs.c > @@ -317,12 +317,12 @@ static int __ffs_ep0_queue_wait(struct ffs_data *ffs, char *data, size_t len) > static int __ffs_ep0_stall(struct ffs_data *ffs) > { > if (ffs->ev.can_stall) { > - pr_vdebug("ep0 stall\n"); > + pr_vdebug("%s: ep0 stall\n", ffs->dev_name); Again, no, please use dev_dbg() instead. Do NOT roll your own debugging macros. You have access to a struct device pointer for this device that the driver is controlling, so please always use that instead. thanks, greg k-h
