Hi Bryan, I love your patch! Perhaps something to improve: [auto build test WARNING on usb/usb-testing] [also build test WARNING on usb/usb-next usb/usb-linus robh/for-next broonie-regulator/for-next lee-mfd/for-mfd-next linus/master v6.3-rc2 next-20230317] [cannot apply to lee-mfd/for-mfd-fixes] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Bryan-O-Donoghue/dt-bindings-regulator-qcom-usb-vbus-regulator-Mark-reg-as-required/20230318-202034 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing patch link: https://lore.kernel.org/r/20230318121828.739424-14-bryan.odonoghue%40linaro.org patch subject: [PATCH v4 13/18] phy: qcom-qmp: Register as a typec switch for orientation detection config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20230319/202303190010.w3QR1CU6-lkp@xxxxxxxxx/config) compiler: m68k-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/76d1e355779b094d3ddb20776b0835215dc3646c git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Bryan-O-Donoghue/dt-bindings-regulator-qcom-usb-vbus-regulator-Mark-reg-as-required/20230318-202034 git checkout 76d1e355779b094d3ddb20776b0835215dc3646c # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash drivers/phy/qualcomm/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Link: https://lore.kernel.org/oe-kbuild-all/202303190010.w3QR1CU6-lkp@xxxxxxxxx/ All warnings (new ones prefixed by >>): drivers/phy/qualcomm/phy-qcom-qmp-combo.c: In function 'qmp_combo_typec_switch_set': >> drivers/phy/qualcomm/phy-qcom-qmp-combo.c:3383:13: warning: variable 'ret' set but not used [-Wunused-but-set-variable] 3383 | int ret = 0; | ^~~ vim +/ret +3383 drivers/phy/qualcomm/phy-qcom-qmp-combo.c 3376 3377 #if IS_ENABLED(CONFIG_PHY_QCOM_QMP_TYPEC) 3378 static int qmp_combo_typec_switch_set(struct typec_switch_dev *sw, 3379 enum typec_orientation orientation) 3380 { 3381 struct qmp_combo *qmp = typec_switch_get_drvdata(sw); 3382 struct phy *dp_phy = qmp->dp_phy; > 3383 int ret = 0; 3384 3385 dev_dbg(qmp->dev, "Toggling orientation current %d requested %d\n", 3386 qmp->orientation, orientation); 3387 3388 qmp->orientation = orientation; 3389 3390 if (orientation == TYPEC_ORIENTATION_NONE) { 3391 if (qmp->init_count) 3392 ret = qmp_combo_dp_power_off(dp_phy); 3393 } else { 3394 if (!qmp->init_count) 3395 ret = qmp_combo_dp_power_on(dp_phy); 3396 } 3397 3398 return 0; 3399 } 3400 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests
