On Thu, Mar 09, 2023 at 10:26:27AM +0100, Greg Kroah-Hartman wrote: > On Thu, Mar 09, 2023 at 05:10:48PM +0800, Ye, Xiang wrote: > > Hi Greg, > > > > Thanks for the review. > > On Thu, Mar 09, 2023 at 08:49:33AM +0100, Greg Kroah-Hartman wrote: > > > On Thu, Mar 09, 2023 at 03:10:56PM +0800, Ye Xiang wrote: > > > > This patch implements the USB part of Intel USB-I2C/GPIO/SPI adapter > > > > device named "La Jolla Cove Adapter" (LJCA). > > > > > > Then why is this called "mfd" in the subject line? > > Sorry, it's a mistake. I forget to change mfd to usb in the commit message > > because I just move the ljca.c from driver/mfd to drivers/usb/misc according > > to previous review comments[1]. And I will address this on v5. > > > > [1] https://www.spinics.net/lists/kernel/msg4708451.html > > > > > > > include/linux/mfd/ljca.h | 95 ++++ > > > > > > Why is this .h file in the mfd directory? > > It's a mistake as well. Will address it by moving include/linux/mfd/ljca.h > > to include/linux/usb/ljca.h. > > Why do you need a .h file at all for such a tiny .c file? If you don't > need it, don't have one please. The ljca.h file is needed because there are three function driver in this series (LJCA-SPI, LJCA-GPIO, and LJCA-I2C) which needs LJCA API to do actual transfers. LJCA-USB can be considered as a transport driver, and the other three function driver use LJCA API to transfer their own packages. -- Thanks Ye Xiang
