>-----Original Message----- >From: Andrew Lunn <andrew@xxxxxxx> >Sent: Thursday, February 16, 2023 10:09 AM >To: Yuiko Oshino - C18177 <Yuiko.Oshino@xxxxxxxxxxxxx> >Cc: enguerrand.de-ribaucourt@xxxxxxxxxxxxxxxxxxxx; Woojung Huh - C21699 ><Woojung.Huh@xxxxxxxxxxxxx>; hkallweit1@xxxxxxxxx; netdev@xxxxxxxxxxxxxxx; >pabeni@xxxxxxxxxx; davem@xxxxxxxxxxxxx; UNGLinuxDriver ><UNGLinuxDriver@xxxxxxxxxxxxx>; linux@xxxxxxxxxxxxxxx; >edumazet@xxxxxxxxxx; linux-usb@xxxxxxxxxxxxxxx; kuba@xxxxxxxxxx >Subject: Re: [PATCH net 1/2] net:usb:lan78xx: fix accessing the LAN7800's >internal phy specific registers from the MAC driver > >EXTERNAL EMAIL: Do not click links or open attachments unless you know the >content is safe > >On Thu, Feb 16, 2023 at 07:20:53AM -0700, Yuiko Oshino wrote: >> Move the LAN7800 internal phy (phy ID 0x0007c132) specific register accesses >to the phy driver (microchip.c). >> >> Fixes: 14437e3fa284f465dbbc8611fd4331ca8d60e986 ("lan78xx: workaround >> of forced 100 Full/Half duplex mode error") > >I would not say this is a fix which needs putting into stable. The architecture is >wrong to do it in the MAC driver, but i don't think it causes real issues? > >So please submit this to net-next, not net. > > Andrew Hi Andrew, Enguerrand reported the below on 20 Dec 2022, therefore, submitting to net. " Some operations during the cable switch workaround modify the register LAN88XX_INT_MASK of the PHY. However, this register is specific to the LAN8835 PHY. For instance, if a DP8322I PHY is connected to the LAN7801, that register (0x19), corresponds to the LED and MAC address configuration, resulting in unapropriate behavior." Thank you. Yuiko