> -----Original Message----- > From: linux-usb-owner@xxxxxxxxxxxxxxx [mailto:linux-usb- > owner@xxxxxxxxxxxxxxx] On Behalf Of stanley.miao > Sent: Thursday, August 20, 2009 12:34 PM > To: Sergei Shtylyov > Cc: linux-usb@xxxxxxxxxxxxxxx; davinci-linux-open- > source@xxxxxxxxxxxxxxxxxxxx > Subject: Re: [PATCH RFC 1/2] MUSB: CPPI 4.1 DMA driver (take 4) > > Have you tested USB gathet Ethernet ? > > It works when MUSB_PIO_ONLY is enabled. > When USB_TI_CPPI41_DMA is enabled, it is able receive data, but isn't > able to transfer data. > > Stanley. Sergei, Is there any other update to this patch ? We have some patches on top of your base version. Kevin and David, There is another TI platform AM3517 which also has same CPPI41 DMA. So even this platform has to use same CPPI41 files but there is an issue on using cppi4.1 core engine (cppi41.c file at arch/arm/mach-XXX). Can we move this cppi41 core part to some arch/arm/common place so that both da8xx and Am3517 can use it ? Or is there any other option ? -Ajay > > Sergei Shtylyov wrote: > > Hello. > > > > stanley.miao wrote: > > > >>> Texas Instruments CPPI 4.1 DMA support for the MUSBMHRDC driver. > >>> <snip> .. > >>> Index: linux-davinci/drivers/usb/musb/Makefile > >>> =================================================================== > >>> --- linux-davinci.orig/drivers/usb/musb/Makefile > >>> +++ linux-davinci/drivers/usb/musb/Makefile > >>> @@ -53,9 +53,13 @@ ifneq ($(CONFIG_MUSB_PIO_ONLY),y) > >>> musb_hdrc-objs += cppi_dma.o > >>> > >>> else > >>> - ifeq ($(CONFIG_USB_TUSB_OMAP_DMA),y) > >>> - musb_hdrc-objs += tusb6010_omap.o > >>> + ifeq ($(CONFIG_USB_TI_CPPI41_DMA),y) > >>> + musb_hdrc-objs += cppi41_dma.o > >>> > >>> + ifeq ($(CONFIG_USB_TUSB_OMAP_DMA),y) > >>> + musb_hdrc-objs += tusb6010_omap.o > >>> + > >>> + endif > >>> endif > >>> endif > >>> endif > >>> > >> > >> You put the "ifeq($(CONFIG_USB_TUSB_OMAP_DMA),y)" in the > >> "ifeq ($(CONFIG_USB_TI_CPPI41_DMA),y) ..... endif". > >> > >> So if CONFIG_USB_TI_CPPI41_DMA is not enabled, tusb6010_omap.c will > >> not be compiled. > > > > Hum, you're right. The patch is broken -- there should be 'else' > > there... > > > >> Stanley. > > > > WBR, Sergei > > > > > > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-usb" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
