Re: [PATCH RFC 1/2] MUSB: CPPI 4.1 DMA driver (take 4)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Have you tested USB gathet Ethernet ?

It works when MUSB_PIO_ONLY is enabled.
When USB_TI_CPPI41_DMA is enabled, it is able receive data, but isn't able to transfer data.

Stanley.

Sergei Shtylyov wrote:
Hello.

stanley.miao wrote:

Texas Instruments CPPI 4.1 DMA support for the MUSBMHRDC driver.
<snip> ..
Index: linux-davinci/drivers/usb/musb/Makefile
===================================================================
--- linux-davinci.orig/drivers/usb/musb/Makefile
+++ linux-davinci/drivers/usb/musb/Makefile
@@ -53,9 +53,13 @@ ifneq ($(CONFIG_MUSB_PIO_ONLY),y)
       musb_hdrc-objs        += cppi_dma.o
else
-      ifeq ($(CONFIG_USB_TUSB_OMAP_DMA),y)
-        musb_hdrc-objs        += tusb6010_omap.o
+      ifeq ($(CONFIG_USB_TI_CPPI41_DMA),y)
+        musb_hdrc-objs        += cppi41_dma.o
+ ifeq ($(CONFIG_USB_TUSB_OMAP_DMA),y)
+          musb_hdrc-objs    += tusb6010_omap.o
+
+        endif
       endif
     endif
   endif

You put the "ifeq($(CONFIG_USB_TUSB_OMAP_DMA),y)" in the
"ifeq ($(CONFIG_USB_TI_CPPI41_DMA),y) ..... endif".

So if CONFIG_USB_TI_CPPI41_DMA is not enabled, tusb6010_omap.c will not be compiled.

Hum, you're right. The patch is broken -- there should be 'else' there...

Stanley.

WBR, Sergei




--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux