On Thu, Jan 12, 2023 at 11:29:40AM +0100, Bjørn Mork wrote:
> Bjørn Mork <bjorn@xxxxxxx> writes:
> > Greg KH <greg@xxxxxxxxx> writes:
> >
> >> No need for this, just backport the original change to older kernels and
> >> all will be fine.
> >>
> >> Don't live with stuff you don't want to because of stable kernels,
> >> that's not how this whole process works at all :)
> >
> > OK, thanks. Will prepare a patch for stable instead then.
> >
> > But I guess the original patch is unacceptable for stable as-is? It
> > changes how Linux react to these devces, and includes a completely new
> > USB device driver (i.e not interface driver).
>
> Doh! I gotta start thinking before I send email. Will start right
> after sending this one ;-)
>
> We cannot backport the device-id table change to stable without taking
> the rest of the patch. The strategy used by the old driver needs two
> entries per device ID, which is why the macro was there.
>
> So the question is: Can commit ec51fbd1b8a2 ("r8152: add USB device
> driver for config selection") be accepted in stable?
>
> ( Direct link for convenience since it's not yet in mainline:
> https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/drivers/net/usb/r8152.c?id=ec51fbd1b8a2bca2948dede99c14ec63dc57ff6b
> )
>
> This is not within the rules as I read them, but it's your call...
Ah, yeah, that's simple enough, I'd take it if you send it to me :)
greg k-h
