On Tue, Oct 27, 2009 at 01:21:21PM -0700, Elina Pasheva wrote:
>
> On Tue, 2009-10-27 at 10:20 -0700, Greg KH wrote:
> > On Fri, Oct 16, 2009 at 12:06:53PM -0700, Elina Pasheva wrote:
> > > #ifdef CONFIG_PM
> > > static void stop_read_write_urbs(struct usb_serial *serial)
> > > {
> > > - int i, j;
> > > + int i;
> > > struct usb_serial_port *port;
> > > struct sierra_port_private *portdata;
> > >
> > > @@ -927,8 +930,7 @@ static void stop_read_write_urbs(struct
> > > for (i = 0; i < serial->num_ports; ++i) {
> > > port = serial->port[i];
> > > portdata = usb_get_serial_port_data(port);
> > > - for (j = 0; j < N_IN_URB; j++)
> > > - usb_kill_urb(portdata->in_urbs[j]);
> > > + sierra_stop_rx_urbs(port);
> > > usb_kill_anchored_urbs(&portdata->active);
> > > }
> > > }
> >
> > This portion of the patch does not belong here, especially as it is also
> > in the 3/3 patch, right?
> Hi Greg,
> This portion of the patch is related to autopm fixes so it needs to be
> in this patch. We made separate patches for the fixes related to autopm
> in case these need to be back-ported.
> PATCH[003/003] does not need this part, my apologies for the mistake.
>
> >
> > Care to redo the 2 and 3 patches in this series, as something isn't
> > quite right here.
> I will re-do PATCH[003/003] (needs the redundant part at the end
> removed), but PATCH[002/003] is correct. Would you please re-consider
> PATCH[002/003] as it is.
Sure, but you will have to resend it, as it's now gone from my queue :)
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
