Re: [PATCH 002/003] USB: serial: sierra driver autopm fixes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Oct 16, 2009 at 12:06:53PM -0700, Elina Pasheva wrote:
>  #ifdef CONFIG_PM
>  static void stop_read_write_urbs(struct usb_serial *serial)
>  {
> -	int i, j;
> +	int i;
>  	struct usb_serial_port *port;
>  	struct sierra_port_private *portdata;
>  
> @@ -927,8 +930,7 @@ static void stop_read_write_urbs(struct 
>  	for (i = 0; i < serial->num_ports; ++i) {
>  		port = serial->port[i];
>  		portdata = usb_get_serial_port_data(port);
> -		for (j = 0; j < N_IN_URB; j++)
> -			usb_kill_urb(portdata->in_urbs[j]);
> +		sierra_stop_rx_urbs(port);
>  		usb_kill_anchored_urbs(&portdata->active);
>  	}
>  }

This portion of the patch does not belong here, especially as it is also
in the 3/3 patch, right?

Care to redo the 2 and 3 patches in this series, as something isn't
quite right here.

And as always, please double check your patches before you send them to
me, so that I don't loose time trying to figure out what in the world is
wrong with them...

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux