On Sat, Nov 12, 2022 at 4:46 PM zhongling0719@xxxxxxx <zhongling0719@xxxxxxx> wrote: > > Hi: > This error not happend on all RTL9210,The uas blacklist only for on sale device(0x0bda, 0x9210). 0x0bda is VendorId for Realtek, 0x9210 is ProductId for the entire RTL9210 enclosures. This patch blacklists UAS for all RTL9210 enclosures. > > Thanks! > > zhongling0719@xxxxxxx > > From: Greg KH > Date: 2022-11-09 18:40 > To: Juhyung Park > CC: Hongling Zeng; stern; linux-usb; usb-storage; zhongling0719 > Subject: Re: [PATCH v6 2/3] usb-storage: Add Hiksemi USB3-FW to IGNORE_UAS > On Mon, Oct 31, 2022 at 03:17:48PM +0900, Juhyung Park wrote: > > Hi, > > > > I'm speaking from my own experience but RTL9210 is arguably the most > > reliable NVMe-to-USB converter available. > > > > Compared to solutions from JMicron (multiple revisions) and ASMedia, RTL9210 > > gave the lowest power consumption (from implementing proper power management > > commands) and the least headache. > > > > I personally own multiple enclosures and not one gave a single UAS error > > from multiple platforms (Android, Intel, AMD) for years, but with this > > commit now, it effectively disables UAS for all RTL9210 enclosures. > > > > Would it be possible to apply this quirk only to a specific firmware > > (range)? RTL9210 have a lot of possible firmware combinations: https://www.station-drivers.com/index.php/en/component/remository/Drivers/Realtek/NVMe-USB-3.1/lang,en-gb/ > > > > RTL9210 was available since 2019 and the fact that this quirk came up this > > late leads me to believe that this is not a widespread issue and it'll be a > > shame if all of RTL9210s are blacklisted from UAS with Linux from now on :( > > > > If any additional information is required, please let me know. > > Can you send a revert of this commit so that we can fix this up? > > thanks, > > greg k-h
