On Mon, Oct 31, 2022 at 03:17:48PM +0900, Juhyung Park wrote: > Hi, > > I'm speaking from my own experience but RTL9210 is arguably the most > reliable NVMe-to-USB converter available. > > Compared to solutions from JMicron (multiple revisions) and ASMedia, RTL9210 > gave the lowest power consumption (from implementing proper power management > commands) and the least headache. > > I personally own multiple enclosures and not one gave a single UAS error > from multiple platforms (Android, Intel, AMD) for years, but with this > commit now, it effectively disables UAS for all RTL9210 enclosures. > > Would it be possible to apply this quirk only to a specific firmware > (range)? RTL9210 have a lot of possible firmware combinations: https://www.station-drivers.com/index.php/en/component/remository/Drivers/Realtek/NVMe-USB-3.1/lang,en-gb/ > > RTL9210 was available since 2019 and the fact that this quirk came up this > late leads me to believe that this is not a widespread issue and it'll be a > shame if all of RTL9210s are blacklisted from UAS with Linux from now on :( > > If any additional information is required, please let me know. Can you send a revert of this commit so that we can fix this up? thanks, greg k-h
