On Tue, Oct 27, 2009 at 10:09:26AM -0700, Robin Callender wrote: > > ----- Original Message ----- > From: "Greg KH" <greg@xxxxxxxxx> > To: "Robin Callender" <robin_callender@xxxxxxxxxxx> > Cc: "linux-usb" <linux-usb@xxxxxxxxxxxxxxx> > Sent: Monday, October 26, 2009 2:37 PM > Subject: Re: [patch 1/2] add support for capture (microphone) to g_audio > > > > On Mon, Sep 21, 2009 at 11:15:19AM -0700, Robin Callender wrote: > >> On Fri, 2009-09-18 at 12:59 -0700, Robin Callender wrote: > >> > This patch section contains (among other things) the modification to > >> > composite.c/h to support routing of setup(endpoint) to the function. > >> > > >> > > >> > Signed-off-by: Robin Callender <robin_callender@xxxxxxxxxxx> > >> > --- > >> > > >> > >> There was a cut&paste error when the patch text was copied into the > >> original email. It omitted the update to u_audio.h to include hid.h > >> This updated patch fixes this problem. > >> > >> BTW, is there a tool for splitting up a large patch into the ~40K limit > >> size? I have been manually creating the emails, which lead to this > >> error. Seems there ought to be some script for handling this. > >> > >> Signed-off-by: Robin Callender <robin_callender@xxxxxxxxxxx> > > > > Is this patch still relevant? What happened to the 2/2 patch? > > > > We need to get David to ack this as well. > > > > thanks, > > > > greg k-h > > > > This patch set contained what I believe to be significant fixes as well as > enhancements to the usb audio gadget driver. > With this patch set the audio driver becomes essentially a usb sound card > device rather than a usb speaker device as it is now. > This patch set still does not bring the usb audio driver into a > well-polished state, but it does correct and add basic functionality upon > which future work can be built. > > I am unsure what you mean by "What happened to 2/2 patch?". > Below is a ref to on of the linux-usb reflectors and I see the complete > patch set there. > http://marc.info/?l=linux-usb&w=2&r=2&s=audio&q=b > http://marc.info/?l=linux-usb&m=125330535613235&w=2 > > I would also suggest Laurent Pinchart review this patch also as it > builds-on and fixes a problem there. > The problem is that the composite layer didn't route the endpoint request to > the functional layer. > This patch include a possible solution for that problem. > http://marc.info/?l=linux-usb&m=125607626100751&w=2 Ok, I'll wait for Laurent to review them. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
