On Mon, Oct 26, 2009 at 09:26:31AM +0200, Artem Bityutskiy wrote: > > No, I don't have all that much PCMCIA hardware -- and specifically none for > > the drivers which were modified in this patch (parport, ixj-telephony, > > sl811; pcmcia_mtd is marked broken anyway). > > This driver is old and ugly, and it is even possible that no one uses it > anymore, so I guess getting clean-ups without testing is ok for it. Which one are you referring to specifically? > However, in that case the clean-up patches should be reviewable, which I > wouldn't say about your patch :-) It are "only" 46 line changes max per driver? > Could you please split it on several smaller patches, each doing one > thing only? Well, I could split up the -- related -- CS_CHECK() and dev_dbg() parts if _really_ necessary. Best, Dominik -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
