On Mon, 2009-10-26 at 08:13 +0100, Dominik Brodowski wrote: > Hey, > > On Mon, Oct 26, 2009 at 08:42:11AM +0200, Artem Bityutskiy wrote: > > On Sat, 2009-10-24 at 21:43 +0200, Dominik Brodowski wrote: > > > Convert PCMCIA drivers to use the dynamic debug infrastructure, instead of > > > requiring manual settings of PCMCIA_DEBUG. > > > > > > Also, remove all usages of the CS_CHECK macro and replace them with proper > > > Linux style calling and return value checking. The extra error reporting may > > > be dropped, as the PCMCIA core already complains about any (non-driver-author) > > > errors. > > > > > > CC: linux-mtd@xxxxxxxxxxxxxxxxxxx > > > CC: linux-usb@xxxxxxxxxxxxxxx > > > Signed-off-by: Dominik Brodowski <linux@xxxxxxxxxxxxxxxxxxxx> > > > > Have you been able to test the driver after the clean-up? > > No, I don't have all that much PCMCIA hardware -- and specifically none for > the drivers which were modified in this patch (parport, ixj-telephony, > sl811; pcmcia_mtd is marked broken anyway). This driver is old and ugly, and it is even possible that no one uses it anymore, so I guess getting clean-ups without testing is ok for it. However, in that case the clean-up patches should be reviewable, which I wouldn't say about your patch :-) Could you please split it on several smaller patches, each doing one thing only? -- Best Regards, Artem Bityutskiy (Артём Битюцкий) -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
