Am Sonntag, 25. Oktober 2009 18:51:00 schrieb bart.hartgers@xxxxxxxxx: > + /* read modem status */ > + unsigned status = atomic_read(&priv->msr); > + /* modem control is output */ > + unsigned ctrl = atomic_read(&priv->mcr); What is the sense of having two atomic variables? You can get races where one is changed but the other is not. Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html